Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eks (unreleased): generated cluster name can exceed 63 characters #5596

Closed
eladb opened this issue Dec 31, 2019 · 0 comments · Fixed by #5597
Closed

eks (unreleased): generated cluster name can exceed 63 characters #5596

eladb opened this issue Dec 31, 2019 · 0 comments · Fixed by #5597
Assignees
@eladb
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. p0

Comments

@eladb
Copy link
Contributor

eladb commented Dec 31, 2019

Since the generated cluster name includes the logical ID of the resource as a prefix with a postfix of the request ID, the resulting generated name can exceed 63 characters.

Reproduction Steps

new eks.Cluster(this, 'VeryLongLogicalIdVeryLongLogicalIdVeryLongLogicalIdVeryLongLogicalIdVeryLongLogicalIdVeryLongLogicalIdVeryLongLogicalIdVeryLongLogicalIdVeryLongLogicalId');

Error Log

Error: Cluster name must be less than 63 characters

Environment

  • CLI Version :
  • Framework Version:
  • OS :
  • Language :

Other

This is 🐛 Bug Report
@eladb eladb added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. p0 labels Dec 31, 2019
@eladb eladb self-assigned this Dec 31, 2019
eladb pushed a commit that referenced this issue Dec 31, 2019
fix(eks): generated cluster name can exceed 63 characters
5b8451a 
Since the generated cluster name includes the logical ID of the resource as a prefix with a postfix of the request ID, the resulting generated name can exceed 63 characters.

Fixes #5596

NOTE: since the current version of the EKS module have not been released yet, this is not a breaking change.
@eladb eladb mentioned this issue Dec 31, 2019
Merged
@mergify mergify bot closed this as completed in #5597 Jan 1, 2020
mergify bot pushed a commit that referenced this issue Jan 1, 2020
@mergify
fix(eks): generated cluster name can exceed 100 characters (#5597)
3256a41 
* fix(eks): generated cluster name can exceed 63 characters

Since the generated cluster name includes the logical ID of the resource as a prefix with a postfix of the request ID, the resulting generated name can exceed 63 characters.

Fixes #5596

NOTE: since the current version of the EKS module have not been released yet, this is not a breaking change.

* add test for cluster name trimming

* reduce to 62 because error message is not clear

* update to 100 chars

* update expectations
eladb pushed a commit that referenced this issue Jan 13, 2020
fix(eks): generated cluster name can exceed 63 characters
89cfa1d 
Since the generated cluster name includes the logical ID of the resource as a prefix with a postfix of the request ID, the resulting generated name can exceed 63 characters.

Fixes #5596

NOTE: since the current version of the EKS module have not been released yet, this is not a breaking change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eladb eladb

Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. p0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(eks): generated cluster name can exceed 100 characters aws/aws-cdk
1 participant
@eladb