Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): "parseArn" is incompatible with "formatArn" for empty fields #5875

Merged
merged 1 commit into from
Jan 20, 2020
Merged

fix(core): "parseArn" is incompatible with "formatArn" for empty fields #5875

merged 1 commit into from
Jan 20, 2020

Conversation

melchii
Copy link
Contributor

@melchii melchii commented Jan 20, 2020 •
edited by eladb
Loading

Fixes #5808

BREAKING CHANGE: Arn.parseArn now returns empty string for undefined components. Users who were depending on an undefined value will now receive the falsy empty string.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@melchii
fix(core): allow empty string components in parseArn
0aba0f8 
fixes #5808

BREAKING CHANGE: Arn.parseArn now returns empty string for nullable Arn
components. Users who were depending on an undefined value will now
receive the falsy empty string.
@melchii melchii requested a review from eladb as a code owner January 20, 2020 13:41
@eladb eladb changed the title fix(core): allow empty string components in parseArn fix(core): "parseArn" wrongly returns "undefined" instead of empty strings Jan 20, 2020
@eladb eladb changed the title fix(core): "parseArn" wrongly returns "undefined" instead of empty strings fix(core): "parseArn" is incompatible with "formatArn" for empty fields Jan 20, 2020
eladb
eladb approved these changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed PR title to reflect the bug fixed and not the solution (it goes under Bug Fixes in the changelog).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jan 20, 2020

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit 5ed5eb4 into aws:master Jan 20, 2020
@melchii melchii deleted the melchii/5808 branch January 20, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

core: stack.parseArn() is incorrect
3 participants
@melchii @aws-cdk-automation @eladb