-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ecs): update minHealthyPercent validation for ec2service #7814
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @iamhopaul123! This looks great overall, but had a couple minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it! 💯 Looks great! Thanks @iamhopaul123!
@iamhopaul123 can you update the description and describe hte previous behaviour as well as the new behaviour. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
@@ -351,7 +351,7 @@ export = { | |||
test.done(); | |||
}, | |||
|
|||
'errors if daemon and minimum not 0'(test: Test) { | |||
'errors if minimum not less than maximum'(test: Test) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: "greater than"?
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Removes unnecessary validation for "minHealthyPercent must be 0 when daemon strategy is set". Additionally, add validation for "minHealthyPercent must less than maxHealthyPercent".
Previously, the Ec2Service will throw an exception when the daemon strategy is used and a non-zero minHealthyPercent is defined. Users will now be allowed to define a minHealthyPercent of greater than zero.
Fixes #7396
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license