chore(cloudfront): Removed duplicate origins in aws-cloudfront module #9326
Conversation
Prior to this change, there were both HttpOrigin and S3Origin classes in both the aws-cloudfront and aws-cloudfront-origins module. The behaviors of the S3Origin classes were also slightly different. This change removes the duplication by removing the aws-cloudfront versions of the origins.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@njlynch I feel like we missed a bunch of BREAKING CHANGES here :(. We should remember to add them to the release notes for the next published CDK version. |
|
Also, ReadMe changes...? |
Whoops! I haven't had to do that yet; totally forgot about it. Can we manually add them into the release notes (and is there a mechanism so we don't forget), or could we do something weird like pushing a no-op PR/commit with just the BREAKING CHANGES notes?
The README already only showed usages of the -origins module, so it's already consistent. |
There's no mechanism to not forget; we just have to remember to add them to the "bump" PR for the next release. Alternatively, since forgetting is a significant risk, I'm fine with pushing an empty PR (assuming GitHub handles those) just for the commit message.
OK. I guess that confirms the changes in this PR were the correct decision 🙂. |
Making a small -- but useful -- README change as an excuse to capture the breaking changes made in #9326, but that were missed in that commit message. BREAKING CHANGE: Removed origin classes from the aws-cloudfront module. * **aws-cloudfront:** Removed S3Origin and HttpOrigin from the aws-cloudfront module. Use the S3Origin and HttpOrigin classes in the aws-cloudfront-origins module instead. * **aws-cloudfront:** Renamed Origin to OriginBase.
Making a small -- but useful -- README change as an excuse to capture the breaking changes made in #9326, but that were missed in that commit message. BREAKING CHANGE: Removed origin classes from the aws-cloudfront module. * **aws-cloudfront:** Removed S3Origin and HttpOrigin from the aws-cloudfront module. Use the S3Origin and HttpOrigin classes in the aws-cloudfront-origins module instead. * **aws-cloudfront:** Renamed Origin to OriginBase. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…aws#9326) Prior to this change, there were both HttpOrigin and S3Origin classes in both the aws-cloudfront and aws-cloudfront-origins module. The behaviors of the S3Origin classes were also slightly different. This change removes the duplication by removing the aws-cloudfront versions of the origins. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…9356) Making a small -- but useful -- README change as an excuse to capture the breaking changes made in aws#9326, but that were missed in that commit message. BREAKING CHANGE: Removed origin classes from the aws-cloudfront module. * **aws-cloudfront:** Removed S3Origin and HttpOrigin from the aws-cloudfront module. Use the S3Origin and HttpOrigin classes in the aws-cloudfront-origins module instead. * **aws-cloudfront:** Renamed Origin to OriginBase. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Prior to this change, there were both HttpOrigin and S3Origin classes in both
the aws-cloudfront and aws-cloudfront-origins module. The behaviors of the
S3Origin classes were also slightly different.
This change removes the duplication by removing the aws-cloudfront versions of
the origins.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license