chore(core): Prereq check - support paths with spaces. #9750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prereq check before `yarn build` fails when there are spaces in the path. This is common for WSL2 on windows. For example, mvn is in the path at `/mnt/c/Program Files/`. Testing - Ran check on linux paths and windows paths with and without spaces. Tested with correct version, wrong version, and missing dep. fixes aws#9749
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
NetaNir
changed the title
|
Thank you, and sorry about that! |
NetaNir
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prereq check before
yarn buildfails when there are spaces in thepath. This is common for WSL2 on windows. For example, mvn is in the
path at
/mnt/c/Program Files/.Testing - Ran check on linux paths and windows paths with and without
spaces. Tested with correct version, wrong version, and missing dep.
fixes #9749
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license