Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kms): cross-stack usage detection depends on NPM tree #15580

Merged
merged 4 commits into from
Jul 16, 2021

Commits on Jul 15, 2021

  1. chore(kms): cross-stack usage detection depends on NPM tree

    KMS keys try to be smart about not generating impossible dependencies
    between multiple stacks, which CodePipeline takes advantage of for
    its support stacks.
    
    However, because the logic that tests for this case has an `instanceof
    Construct` in its code path, if there are ever multiple copies of the
    `constructs` library in the NPM tree the test will fail, and the
    resulting error will be very confusing.
    
    This situation can arise when people flip back and forth between
    CDK v1 and v2, because `package-lock.json` will contain half-baked
    dependency trees; people will be looking at their code but the issue
    will be in invisible state.
    
    Be more liberal in detecting that a construct is, in fact, a construct
    to get around this.
    rix0rrr committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    f9c1475 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2021

  1. Undo accidental slip-in

    rix0rrr committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    5944036 View commit details
    Browse the repository at this point in the history
  2. Does not compile

    rix0rrr committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    0216912 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    85f54f2 View commit details
    Browse the repository at this point in the history