docs(ec2): document how to correctly make cross stack connection calls #18796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds documentation on how to correctly make cross stack connections. If the connection is not made in the correct stack it can lead to cyclic reference. fixes #5047
|
|
github-actions
bot
added
the
@aws-cdk/aws-ec2
madeline-k
reviewed
Feb 23, 2022
|
|
||
| // Stack 2 | ||
| const sg2 = new ec2.SecurityGroup(this, 'SG2', { | ||
| allowAllOutbound: false, // if this is `true` then no egress rule will be created |
There was a problem hiding this comment.
The examples probably should not use the same scope for sg1 and sg2, because they are supposed to be in different stacks. I think this could be confusing.
There was a problem hiding this comment.
Good point. Updated!
otaviomacedo
approved these changes
Mar 4, 2022
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TheRealAmazonKendra
pushed a commit
to TheRealAmazonKendra/aws-cdk
that referenced
this pull request
Mar 11, 2022
aws#18796) This PR adds documentation on how to correctly make cross stack connections. If the connection is not made in the correct stack it can lead to cyclic reference. fixes aws#5047 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation on how to correctly make cross stack
connections. If the connection is not made in the correct stack it can
lead to cyclic reference.
fixes #5047
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license