Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): raise integ test timeout #23812

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jan 24, 2023

The timeout needs to account for the worst-case running time of all tests, single-threaded.

This is because a test may be started, but never be able to acquire the lock until all other tests have run.

Set it to 2hrs (currently, the test suite takes ~90 minutes to run single-threaded).


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The timeout needs to account for the worst-case running time of all
tests, single-threaded.

This is because a test may be started, but never be able to acquire the
lock until all other tests have run.

Set it to 2hrs (currently, the test suite takes ~90 minutes to run
single-threaded).
@rix0rrr rix0rrr requested a review from a team January 24, 2023 11:18
@rix0rrr rix0rrr self-assigned this Jan 24, 2023
@gitpod-io
Copy link

gitpod-io bot commented Jan 24, 2023

@github-actions github-actions bot added the p2 label Jan 24, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team January 24, 2023 11:18
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 24, 2023
@rix0rrr rix0rrr added the pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested label Jan 24, 2023
@mergify
Copy link
Contributor

mergify bot commented Jan 24, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8191421
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit ba14612 into main Jan 24, 2023
@mergify mergify bot deleted the huijbers/integ-test-timeout branch January 24, 2023 13:38
@mergify
Copy link
Contributor

mergify bot commented Jan 24, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants