Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stepfunctions): removal policy for state machines #24105

Merged
merged 3 commits into from
Feb 20, 2023

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Feb 10, 2023

Add the removalPolicy prop to StateMachine.

The execution history can be considered as stateful.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Feb 10, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team February 10, 2023 10:58
@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Feb 10, 2023
*
* @default RemovalPolicy.DESTROY
*/
readonly removalPolicy?: RemovalPolicy;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would adding this props trigger a replacement on the resource? If so, adding a removal policy to retain would, actually delete what they're trying to retain.

Copy link
Contributor Author

@jogold jogold Feb 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it doesn't. It's a CF attribute not a resource property.

@mergify
Copy link
Contributor

mergify bot commented Feb 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@jogold
Copy link
Contributor Author

jogold commented Feb 20, 2023

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Feb 20, 2023

update

❌ Base branch update has failed

refusing to allow a GitHub App to create or update workflow .github/workflows/issue-label-assign.yml without workflows permission
err-code: C85B2

@jogold
Copy link
Contributor Author

jogold commented Feb 20, 2023

@Mergifyio rebase

Add the `removalPolicy` prop to `StateMachine`.

The exeuction history can be considered as stateful.
@mergify
Copy link
Contributor

mergify bot commented Feb 20, 2023

⚠️ This pull request got rebased on behalf of a random user of the organization.
This behavior will change on the 1st February 2023, Mergify will pick the author of the pull request instead.

To get the future behavior now, you can configure bot_account options (e.g.: bot_account: { author } or update_bot_account: { author }.

Or you can create a dedicated github account for squash and rebase operations, and use it in different bot_account options.

@mergify
Copy link
Contributor

mergify bot commented Feb 20, 2023

rebase

✅ Branch has been successfully rebased

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9f5677e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5f33a26 into aws:main Feb 20, 2023
@jogold jogold deleted the sfn-removal-policy branch December 30, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants