-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(region-info): facts only returned from constant region list #27506
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@returns the list of names of AWS regions for which there is at least one registered fact.
In my opionion updating the regions()
method to return Array.from(Object.keys(this.database))
is the way to go here.
Also, the PR should be a fix
.
@lpizzinidev Updated per your feedback—thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
@lpizzinidev For this, I think it makes sense to ignore the linter error about integration tests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
I agree that an integration test is not necessary in this case.
Also, the title should be updated to describe the bug fixed.
@lpizzinidev I updated the title per your recommendation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👍
@kaizencc Can you this be approved/merged without the linter passing? |
Exemption Request
|
This has been "static" for a long time now: I'm also concerned that we are using this list in other places and rely on it containing all regions. Can we change the code and description so that it includes all AWS Regions plus any custom defined regions? |
@mrgrain Updated per your recommendation. Thanks! |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Facts are only being returned from the regions in a constant list. This PR returns facts for all Regions in `AWS_REGIONS` + `this.database`. Closes #27260. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Facts are only being returned from the regions in a constant list.
This PR returns facts for all Regions in
AWS_REGIONS
+this.database
.Closes #27260.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license