Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(synthetics): deprecate nodejs runtimes #29472

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Mar 13, 2024

Per this doc, these 5 runtimes were deprecated on March 8, 2024.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the star-contributor [Pilot] contributed between 25-49 PRs to the CDK label Mar 13, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 13, 2024 17:09
@github-actions github-actions bot added the p2 label Mar 13, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 13, 2024
@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Mar 13, 2024
gracelu0
gracelu0 previously approved these changes Mar 14, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 14, 2024
@msambol
Copy link
Contributor Author

msambol commented Mar 14, 2024

@Mergifyio refresh

@msambol
Copy link
Contributor Author

msambol commented Mar 14, 2024

@gracelu0 do you mind merging in main here?

Copy link
Contributor

mergify bot commented Mar 14, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Mar 14, 2024

refresh

✅ Pull request refreshed

@mergify mergify bot dismissed gracelu0’s stale review March 14, 2024 19:21

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 14, 2024
Copy link
Contributor

mergify bot commented Mar 14, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@msambol
Copy link
Contributor Author

msambol commented Mar 14, 2024

@gracelu0 I screwed something up 🤦🏼‍♂️ Do you mind re-approving?

Copy link
Contributor

mergify bot commented Mar 14, 2024

refresh

✅ Pull request refreshed

Copy link
Contributor

mergify bot commented Mar 14, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 14, 2024
Copy link
Contributor

mergify bot commented Mar 14, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@paulhcsun
Copy link
Contributor

@Mergifyio update

Copy link
Contributor

mergify bot commented Mar 14, 2024

update

☑️ Nothing to do

  • queue-position=-1 [📌 update requirement]
  • #commits-behind>0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 11d332c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 3c1307e into aws:main Mar 14, 2024
9 checks passed
Copy link
Contributor

mergify bot commented Mar 14, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants