Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(triggers): store provider as class property #29669

Closed
wants to merge 5 commits into from

Conversation

automartin5000
Copy link

Issue # (if applicable)

Closes #29657

Reason for this change

Unable to modify Triggers provider using conventional escape hatches

Description of changes

Stored Trigger provider as class property to be user-accessible

Description of how you validated changes

Was unable to test changes due to issues getting project installed locally

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team April 1, 2024 02:29
@github-actions github-actions bot added bug This issue is a bug. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Apr 1, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@automartin5000
Copy link
Author

Clarification Request
I can't tell why builds are failing. There seem to be a lot of unrelated failures? The only thing I can tell is a linting error in the Trigger file, but that looks to have already been there?

Also does this need an integration test beyond the tests I already added? If so where would it go/what would it do?

@aws-cdk-automation aws-cdk-automation added the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Apr 3, 2024
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I have just one comment inline but I think we also need to see an integ test added for this to show that it works for your intended use case.

* Singleton Trigger provider
* @type {CustomResourceProvider}
*/
crProvider: CustomResourceProvider;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we either call this provider or use the whole customResourceProvider?

@TheRealAmazonKendra
Copy link
Contributor

Also, please note that the title of a fix should describe the bug, not the solution. Could you please adjust that?

@TheRealAmazonKendra
Copy link
Contributor

@Mergifyio update

Copy link
Contributor

mergify bot commented Apr 9, 2024

update

✅ Branch has been successfully updated

@TheRealAmazonKendra
Copy link
Contributor

Also, I hadn't noticed that your build failed and that you asked a question about it. The failure lines here are pretty hard to find but they're:

aws-cdk-lib:   116:36  error  Trailing spaces not allowed  no-trailing-spaces
aws-cdk-lib: ✖ 1 problem (1 error, 0 warnings)
aws-cdk-lib:   1 error and 0 warnings potentially fixable with the `--fix` option.

The docstring on line 116 of trigger.ts is running afoul of our linter. The other lines that look like failures are just jsii warnings. They are noisy but they don't cause failures.

@TheRealAmazonKendra TheRealAmazonKendra removed the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Apr 9, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5413315
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label May 7, 2024
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

triggers: Trigger provider does not show up in construct tree
3 participants