Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

triggers: Trigger provider does not show up in construct tree #29657

Open
automartin5000 opened this issue Mar 31, 2024 · 1 comment
Open

triggers: Trigger provider does not show up in construct tree #29657

automartin5000 opened this issue Mar 31, 2024 · 1 comment
Labels
@aws-cdk/triggers Related to the triggers package bug This issue is a bug. effort/small Small work item – less than a day of effort p3

Comments

@automartin5000
Copy link

automartin5000 commented Mar 31, 2024

Describe the bug

The Trigger provider construct and its children don't seem to be showing up in the Construct tree. This means that it can't be used with Aspects to apply tags or execute any kind of overrides.

Expected Behavior

  1. This should return the trigger resource provider.
const triggerCustomResourceProvider = stack.node.tryFindChild(
      "AWSCDK.TriggerCustomResourceProvider",
    );
  1. Similarly, this should allow me to make modifications to the Trigger resources
Aspects.of(stack).add(new SomeModificationToTrigger());

Current Behavior

  1. tryFindChild returns undefined
  2. Aspects does not pass the class any of the children resources of the Trigger Provider
  3. Listing the entire construct tree via console.log(stack.node.findAll().map((n) => n.node.path)); does not show the Trigger provider constructs

Reproduction Steps

This was tested in two places: Fine-grained assertion tests and Python code using the published code from a custom CDK library.

Possible Solution

Convert this to a class property to be accessible by end users.

Possibly the use of a . in the construct ID is causing this? Could it be as simple as maybe removing that or switching to a -?`

Disregard previous hypothesis. I was able to add a construct with a . and it was listed in findAll().

Additional Information/Context

No response

CDK CLI Version

2.131.0

Framework Version

No response

Node.js Version

20

OS

macOS Sonoma

Language

TypeScript

Language Version

No response

Other information

No response

@automartin5000 automartin5000 added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 31, 2024
@github-actions github-actions bot added the @aws-cdk/triggers Related to the triggers package label Mar 31, 2024
@tim-finnigan tim-finnigan self-assigned this Apr 1, 2024
@tim-finnigan tim-finnigan added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Apr 1, 2024
@tim-finnigan
Copy link

Thanks for reporting this issue and creating the PR.

@tim-finnigan tim-finnigan added p2 effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Apr 1, 2024
@tim-finnigan tim-finnigan removed their assignment Apr 1, 2024
@pahud pahud added p3 and removed p2 labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/triggers Related to the triggers package bug This issue is a bug. effort/small Small work item – less than a day of effort p3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants