Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bedrock): add missing models and fix typo #30668

Merged
merged 7 commits into from
Jun 26, 2024

Conversation

mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented Jun 26, 2024

Add missing models.

ai21.j2-ultra-v1:0:8k
ai21.jamba-instruct-v1:0
amazon.titan-embed-text-v2:0:8k
anthropic.claude-3-5-sonnet-20240620-v1:0
cohere.embed-english-v3:0:512
cohere.embed-multilingual-v3:0:512
mistral.mistral-small-2402-v1:0

Also, fix typo.
ccohere.command-r-v1:0 -> cohere.command-r-v1:0

Ref:

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the star-contributor [Pilot] contributed between 25-49 PRs to the CDK label Jun 26, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team June 26, 2024 00:05
@github-actions github-actions bot added the p2 label Jun 26, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 26, 2024
Copy link
Contributor

@nmussy nmussy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few more changes to be made, if you want to add them:

+ ai21.j2-ultra-v1:0:8k
+ ai21.jamba-instruct-v1:0
+ amazon.titan-embed-text-v2:0:8k
+ anthropic.claude-3-5-sonnet-20240620-v1:0
+ cohere.command-r-v1:0
+ cohere.embed-english-v3:0:512
+ cohere.embed-multilingual-v3:0:512
+ mistral.mistral-small-2402-v1:0
- anthropic.claude-3-opus-20240229-v1:0
- ccohere.command-r-v1:0

The models listed as "removed" should be deprecated

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 26, 2024
@mazyu36 mazyu36 changed the title chore(bedrock): add jamba-instruct model chore(bedrock): add missing models and fix typo Jun 26, 2024
@mazyu36
Copy link
Contributor Author

mazyu36 commented Jun 26, 2024

@nmussy
Thanks.
I've added missing models.

anthropic.claude-3-5-sonnet-20240620-v1:0

This has already been added at #30629.

anthropic.claude-3-opus-20240229-v1:0

This model is only available in Oregon region.
(Claude 3 Opus is the most advanced and intelligent model in the Claude 3 Family,)

I think this model should not be removed.

% aws bedrock get-foundation-model --model-identifier anthropic.claude-3-opus-20240229-v1:0 --region us-west-2

{
    "modelDetails": {
        "modelArn": "arn:aws:bedrock:us-west-2::foundation-model/anthropic.claude-3-opus-20240229-v1:0",
        "modelId": "anthropic.claude-3-opus-20240229-v1:0",
        "modelName": "Claude 3 Opus",
        "providerName": "Anthropic",
        "inputModalities": [
            "TEXT",
            "IMAGE"
...
ccohere.command-r-v1:0

I think this is a typo for cohere.command-r-v1:0.😅
I've fixed.

@nmussy
Copy link
Contributor

nmussy commented Jun 26, 2024

This model is only available in Oregon region.

You're absolutely right, I'd forgotten about the region exclusive models. In fact, us-west-2 doesn't have amazon.titan-text-premier-v1:0

Co-authored-by: Jimmy Gaussen <jimmy.gaussen@gmail.com>
Copy link
Contributor

@nmussy nmussy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changes 👍

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 26, 2024
paulhcsun
paulhcsun previously approved these changes Jun 26, 2024
@paulhcsun
Copy link
Contributor

@Mergifyio update

Copy link
Contributor

mergify bot commented Jun 26, 2024

update

✅ Branch has been successfully updated

Copy link
Contributor

mergify bot commented Jun 26, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 26, 2024
@mergify mergify bot dismissed paulhcsun’s stale review June 26, 2024 21:09

Pull request has been modified.

@paulhcsun
Copy link
Contributor

@Mergifyio update

Copy link
Contributor

mergify bot commented Jun 26, 2024

update

☑️ Nothing to do

  • #commits-behind>0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]
  • queue-position=-1 [📌 update requirement]

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c708385
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Jun 26, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit dfc12aa into aws:main Jun 26, 2024
12 checks passed
@mazyu36 mazyu36 deleted the bedrock-ai21-jamba-instruct branch June 27, 2024 15:05
This was referenced Jul 1, 2024
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants