chore(scripts): builddown should use foreach to support resuming builds #8784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buildup and builddown currently use two entirely different approaches. This fix makes the builddown mirror the current buildup script, and alters foreach to support a --down flag in addition to --up.
nija-at
suggested changes
Jun 29, 2020
scripts/foreach.sh
Outdated
Comment on lines
87
to
88
| up=" --scope ${scope} --include-dependents" | ||
| up_desc="('${scope}' and its consumers)" |
There was a problem hiding this comment.
copy pasta typo in variable names.
Might be worth defining just 2 vars - direction and direction_desc - and use the same variables for both up and down.
nija-at
approved these changes
Jun 29, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildup and builddown currently use two entirely different approaches.
This fix makes the builddown mirror the current buildup script, and alters foreach to
support a --down flag in addition to --up.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license