-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ec2): natGateways=0 disables private subnets #8817
Conversation
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
[ACTIONABLES]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work!
some minor suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added do-not-merge
so @rix0rrr also has a chance to review
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
[ISSUE]
If
natGateways: 0
in VPC but with no subnet configuration. If 0 NAT gateways, private subnets are effectively isolated subnets so it would be a nice-to-have to allow this configuration to construct without errors.[APPROACH]
Added another default subnet configuration called
DEFAULT_SUBNET_NO_NAT
that does an even split of Public and Isolated Subnets.Added a check before
subnetConfiguration
to determine which is 'default' configuration to use.[NOTE]
Previous use cases should be untouched, changes adjust for our customers' requests to allow for easy configuration.
Closes #4814
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license