Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The CLI completer can throw tracebacks on SIGINT (Ctrl+C) #628

Closed
jcmcken opened this issue Feb 3, 2014 · 0 comments · Fixed by #633
Closed

The CLI completer can throw tracebacks on SIGINT (Ctrl+C) #628

jcmcken opened this issue Feb 3, 2014 · 0 comments · Fixed by #633

Comments

@jcmcken
Copy link

jcmcken commented Feb 3, 2014

If a user Ctrl+C's during the completion lookup, nasty tracebacks can be thrown from wherever in the stack the execution is cancelled. This doesn't cause any major problems as far as I'm aware, but it is a little user-unfriendly.
@jamesls jamesls mentioned this issue Feb 5, 2014
Merged
jamesls added a commit to jamesls/botocore that referenced this issue Feb 5, 2014
@jamesls
Never catch a bare except clause
a6337a3 
While investigating aws/aws-cli#628 I noticed that I'd still
occasionally get tracebacks, particularly a DataNotFoundError
from botocore's base.py module.  After further investigation,
this was because the bare except clauses were catching the
KeyboardInterrupts and swallowing them.  This resulted in a
traceback somewhere downstream.

The specific error I hit from aws/aws-cli#628 was from base.py,
but I did a quick search through the code and for the time being
at least replaced the bare excepts with except Exception.  There's
potential to switch some of these to more specific exceptions later.
@jamesls jamesls mentioned this issue Feb 5, 2014
Merged
@jamesls jamesls closed this as completed in 83548aa Feb 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't print tracebacks if completer is interrupted jamesls/aws-cli
1 participant
@jcmcken