Remove all bare except clauses #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While investigating aws/aws-cli#628 I noticed that I'd still occasionally get tracebacks, particularly a DataNotFoundError from botocore's base.py module. After further investigation, this was because the bare except clauses were catching the KeyboardInterrupts and swallowing them. This resulted in a traceback somewhere downstream. The specific error I hit from aws/aws-cli#628 was from base.py, but I did a quick search through the code and for the time being at least replaced the bare excepts with except Exception. There's potential to switch some of these to more specific exceptions later.
|
Looks better, so |
!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating aws/aws-cli#628 I noticed that I'd still
occasionally get tracebacks, particularly a DataNotFoundError
from botocore's base.py module. After further investigation,
this was because the bare except clauses were catching the
KeyboardInterrupts and swallowing them. This resulted in a
traceback somewhere downstream.
The specific error I hit from aws/aws-cli#628 was from base.py,
but I did a quick search through the code and for the time being
at least replaced the bare excepts with except Exception. There's
potential to switch some of these to more specific exceptions later.