Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the brand new 4.x release of pyyaml #3414

Closed
wants to merge 1 commit into from
Closed

Allow the brand new 4.x release of pyyaml #3414

wants to merge 1 commit into from

Conversation

asottile
Copy link
Contributor

the most important "breaking" change of pyyaml 4.x is the move to "safe by default" -- I browsed awscli's usage of pyyaml and it looks like the safe loader is already being used

@asottile
Copy link
Contributor Author

(I initially ran into this from the following warning from pip):

awscli 1.15.46 has requirement PyYAML<=3.12,>=3.10, but you'll have pyyaml 4.1 which is incompatible.

@codecov-io
Copy link

codecov-io commented Jun 27, 2018

Codecov Report

Merging #3414 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #3414   +/-   ##
=======================================
  Coverage     94.4%   94.4%           
=======================================
  Files          169     169           
  Lines        13223   13223           
=======================================
  Hits         12483   12483           
  Misses         740     740

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce93d2a...f5611b0. Read the comment docs.

@hugovk
Copy link
Contributor

hugovk commented Jun 27, 2018

👍

This should also fix problems installing awscli on Python 3.7: yaml/pyyaml#126.

(Python 3.7 is due for release today, 2018-06-27: https://www.python.org/dev/peps/pep-0537/)

How about adding 3.7-dev to .travis.yml and py37 to tox.ini in this PR?

@asottile
Copy link
Contributor Author

the problem with travis-ci's 3.7-dev is it's 3.7.0a4 which is quite different from the 3.7.0 final that's going to be released this week. most of this is due to travis being stuck on trusty (3.7.0 will require libssl 1.0.2, whereas trusty only has 1.0.1)

@asottile
Copy link
Contributor Author

asottile commented Jul 3, 2018

well it got pulled, wonderful!

@asottile
Copy link
Contributor Author

asottile commented Jul 6, 2018

I've opened #3430 for the just-released 3.13

thoward-godaddy pushed a commit to thoward-godaddy/aws-cli that referenced this pull request Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants