Added support for warning about and skipping files. #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes: #856 |
| @@ -625,8 +630,10 @@ def run(self): | |||
| # keeping it simple and saying that > 0 failed tasks | |||
| # will give a 1 RC. | |||
| rc = 0 | |||
| if files[0] > 0: | |||
There was a problem hiding this comment.
The comment above this is out of date. We should get this comment updated.
|
Looks good, just a couple of minor points:
|
|
LGTM 👍 |
|
Newest version is compatible with Windows. This includes being able to ignore files that do not exists and files that the user does not have permission to. Also, pull request now fixes: |
| if os.path.isdir(path): | ||
| try: | ||
| os.listdir(path) | ||
| except Exception: |
There was a problem hiding this comment.
I would expected these to only catch their appropriate errors OSError (and IOError in py2).
|
Don't forget to update the changelog as well. |
Looks good! Also, a few things to watch out for:
Files that do not exist or user does not have read access to are skipped and users are warned that the file is skipped.
Files include character special devices, block special devices, FIFO, and sockets.
kyleknap
added a commit
that referenced
this pull request
Aug 19, 2014
Added support for warning about and skipping files.
This was referenced Aug 20, 2014
thoward-godaddy
pushed a commit
to thoward-godaddy/aws-cli
that referenced
this pull request
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files that do not exist or user does not have read access to
are skipped and users are warned that the file is skipped.