-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for warning about and skipping files. #881
Conversation
Fixes: #856 |
@@ -625,8 +630,10 @@ def run(self): | |||
# keeping it simple and saying that > 0 failed tasks | |||
# will give a 1 RC. | |||
rc = 0 | |||
if files[0] > 0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment above this is out of date. We should get this comment updated.
Looks good, just a couple of minor points:
|
LGTM 👍 |
Newest version is compatible with Windows. This includes being able to ignore files that do not exists and files that the user does not have permission to. Also, pull request now fixes: |
if os.path.isdir(path): | ||
try: | ||
os.listdir(path) | ||
except Exception: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expected these to only catch their appropriate errors OSError
(and IOError
in py2).
Don't forget to update the changelog as well. |
Files that do not exist or user does not have read access to are skipped and users are warned that the file is skipped.
Files include character special devices, block special devices, FIFO, and sockets.
Added support for warning about and skipping files.
Files that do not exist or user does not have read access to
are skipped and users are warned that the file is skipped.