aws s3 fails in it encounters a socket file and program hangs

[woodnt]

aws s3 sync fails if it encounters a socket file as in:

# aws s3 cp /home/beth/.config/chromium/SingletonSocket s3://HIDDEN/home/beth/.config/chromium/
upload failed: ../home/beth/.config/chromium/SingletonSocket to s3://HIDDEN/home/beth/.config/chromium/SingletonSocket [Errno 6] No such device or address: u'/home/beth/.config/chromium/SingletonSocket'

The expected behavior is to deal with it, skip it, or fail (preferably not the last as it makes s3 ineffective as a backup solution).

I would recommend that aws s3 as it is dealing with files only work with directory and regular files (with link dereferencing as an option). I fear it will fail on other file types, too, like pipes, block files, and character device files. These should all be handle gracefully.

It should also not completely hang the program. Double Ctrl-C fails to cancel it (clean up). One must find the process number and kill it.

[kyleknap]

Closing, issue is fixed via #881 and is now merged into the develop.