Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhook-http-proxy-test: print squid logs on failure and improve access log grep #214

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

bwagner5
Copy link
Contributor

Issue #, if available:
N/A

Description of changes:

  • webhook-http-proxy-test
    • print squid logs on failure
    • improve access log grep to only look for the webhook proxy server address

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bwagner5 bwagner5 requested a review from cjerad July 24, 2020 16:27
@codecov-commenter
Copy link

Codecov Report

Merging #214 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #214   +/-   ##
=======================================
  Coverage   81.43%   81.43%           
=======================================
  Files          10       10           
  Lines         792      792           
=======================================
  Hits          645      645           
  Misses        131      131           
  Partials       16       16           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0610b4...899999c. Read the comment docs.

Copy link
Contributor

@cjerad cjerad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@cjerad cjerad merged commit 8bf43a9 into aws:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants