squid fixes for webhook-http-proxy-test #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
=======================================
Coverage 81.43% 81.43%
=======================================
Files 10 10
Lines 792 792
=======================================
Hits 645 645
Misses 131 131
Partials 16 16 Continue to review full report at Codecov.
|
brycahta
approved these changes
Jul 24, 2020
cjerad
approved these changes
Jul 24, 2020
test/e2e/webhook-http-proxy-test
Outdated
| squid_worker_pods="" | ||
| for i in `seq 1 10`; do | ||
| echo "Checking if squid http-proxy has started..." | ||
| squid_worker_pods=$(kubectl get pods -o json | jq '.items[] | select( .metadata.name | contains("squid") ) | .metadata.name as $name | select( .spec.nodeName | contains("worker") ) | .spec.nodeName as $nodename | $name' -r || :) |
There was a problem hiding this comment.
Minor: could that command be put in a function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#214
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.