-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Have GitHub workflows build functional tests #419
Conversation
Failing CI actions are an artifact of how the distcheck build is setup, and it needs an update. Will fix that up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your commit subject line is too long, and it would be great to have a bit more in the commit message about the issue you're fixing.
Please check the refactor of this I have in #420 and consider whether you can rebase atop it. |
Fixed CI and commit message.
Just noticed this, yeah I can rebase given your PR gets at more of the workflow changes. |
00b22db
to
706dd34
Compare
bot:aws:retest |
Please merge master. |
ecd73d4
to
0266199
Compare
My review, and we reworked the patch since then.
Use the EFA installer to get the Libfabric and MPI dependencies. Previously, we thought we only needed Libfabric, but to build the functional tests, we need MPI and it's better to build the functional tests. Signed-off-by: Raghu Raja <raghunch@amazon.com>
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.