test: Have GitHub workflows build functional tests #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauteric
previously approved these changes
May 20, 2024
|
Failing CI actions are an artifact of how the distcheck build is setup, and it needs an update. Will fix that up. |
bwbarrett
previously approved these changes
May 20, 2024
Please check the refactor of this I have in #420 and consider whether you can rebase atop it. |
|
Fixed CI and commit message.
Just noticed this, yeah I can rebase given your PR gets at more of the workflow changes. |
rauteric
previously approved these changes
May 21, 2024
rajachan
force-pushed
the
test-mpi-fix
branch
2 times, most recently
from
00b22db
to
706dd34
Compare
AvivBenchorin
added
BuildTriggerRequest
|
bot:aws:retest |
a-szegel
removed
the
BuildTriggerRequest
|
Please merge master. |
bwbarrett
force-pushed
the
test-mpi-fix
branch
3 times, most recently
from
ecd73d4
to
0266199
Compare
bwbarrett
previously requested changes
Jun 7, 2024
bwbarrett
changed the title
bwbarrett
dismissed
their stale review
My review, and we reworked the patch since then.
Use the EFA installer to get the Libfabric and MPI dependencies. Previously, we thought we only needed Libfabric, but to build the functional tests, we need MPI and it's better to build the functional tests. Signed-off-by: Raghu Raja <raghunch@amazon.com>
rauteric
approved these changes
Jun 17, 2024
aws-nslick
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.