Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] sharp issue for new pdk project #627

Closed
cogwirrel opened this issue Nov 1, 2023 · 1 comment
Closed

[BUG] sharp issue for new pdk project #627

cogwirrel opened this issue Nov 1, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@cogwirrel
Copy link
Member

Describe the bug

Adding this retrospectively as it's been fixed in 0.22.25.

In PDK 0.22.21, 0.22.22, 0.22.23 and 0.22.24, sharp was not correctly bundled and so infrastructure projects using CDK graph would fail to synth with an error like the following:

myinfra: build » post-compile » synth:silent | cdk synth -q
myinfra: /Users/user/project/node_modules/.pnpm/@aws+pdk@0.22.24_@aws-cdk+aws-cognito-identitypool-alpha@2.93.0-alpha.0_@pnpm+logger@5.0.0_@t_f325zdutzsxlp3kcnyp5hzmrny/node_modules/@aws/pdk/node_modules/sharp/lib/sharp.js:37
myinfra:   throw new Error(help.join('\n'));
myinfra:         ^
myinfra: Error:
myinfra: Something went wrong installing the "sharp" module
myinfra: Cannot find module '../build/Release/sharp-darwin-x64.node'

Expected Behavior

Synth to succeed, with graph generated

Current Behavior

myinfra: :space_invader: build » post-compile » synth:silent | cdk synth -q
myinfra: /Users/user/project/node_modules/.pnpm/@aws+pdk@0.22.24_@aws-cdk+aws-cognito-identitypool-alpha@2.93.0-alpha.0_@pnpm+logger@5.0.0_@t_f325zdutzsxlp3kcnyp5hzmrny/node_modules/@aws/pdk/node_modules/sharp/lib/sharp.js:37
myinfra:   throw new Error(help.join('\n'));
myinfra:         ^
myinfra: Error:
myinfra: Something went wrong installing the "sharp" module
myinfra: Cannot find module '../build/Release/sharp-darwin-x64.node'

Reproduction Steps

Follow getting started guide

Possible Solution

No response

Additional Information/Context

No response

PDK version used

0.22.24

What languages are you seeing this issue on?

Typescript, Java, Python

Environment details (OS name and version, etc.)

osx

@cogwirrel cogwirrel added the bug Something isn't working label Nov 1, 2023
@cogwirrel
Copy link
Member Author

Fixed in 0.22.25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant