-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pdk-monorepo): pin syncpack dependency to stay compatible to NodeJS v18 #824
Conversation
👋 syncpack v13 should also work for you on Node 18, I reverted the dependency bump which required v20 https://github.com/JamieMason/syncpack/releases/tag/13.0.0 |
… to NodeJS v18" This reverts commit 383541e.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2d27382. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Thanks for this! Looks like you might need to update more snapshots - can be a bit fiddly with monorepo changes as PDK dogfoods itself :) |
@cogwirrel, I don't know why it still fails. I can run the |
Thanks for your contribution @bweigel! 🙌 |
fixes #823