-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Add dotnet
BuildMethod in addition to dotnet7
#7463
Comments
I can try to find time to implement this if you think it makes sense and don't see any potential problems with it. |
Thanks @Beau-Gosse-dev for the feature request. Let me check with the team and get back to you. |
Hello @Beau-Gosse-dev, I checked with the team and they seem fine with the idea. Feel free to work on the feature request. |
Closing as the change was release as part of SAM CLI version 1.127.0. Thanks for your contributions! |
|
Describe your idea/feature/enhancement
There is a custom build method called donet7 shown here:
aws-sam-cli/samcli/lib/build/workflow_config.py
Line 150 in 9f956df
This command isn't really specific to version 7 of .NET since it just calls into the underlying Lambda Builder for dotnet in general and the AWS extensions for the .NET CLI figures out what version of .NET it's building.
Proposal
dotnet7
could be replaced withdotnet
to allow future custom runtime/provided runtime builds for .NET 9 and other non-Lambda supported .NET runtimes. However, to keep backwards compatibility, we could instead just adddotnet
as a build method in addition todotnet7
Things to consider:
dotnet7
mentioned in the docsAdditional Details
Here is the CR for when dotnet7 was added: https://github.com/aws/aws-sam-cli/pull/4410/files
The text was updated successfully, but these errors were encountered: