Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add dotnet BuildMethod in addition to dotnet7 #7463

Closed
Beau-Gosse-dev opened this issue Sep 10, 2024 · 5 comments
Closed

Feature request: Add dotnet BuildMethod in addition to dotnet7 #7463

Beau-Gosse-dev opened this issue Sep 10, 2024 · 5 comments
Labels
area/build sam build command type/feature Feature request

Comments

@Beau-Gosse-dev
Copy link
Contributor

Describe your idea/feature/enhancement

There is a custom build method called donet7 shown here:

"dotnet7": BasicWorkflowSelector(DOTNET_CLIPACKAGE_CONFIG),

This command isn't really specific to version 7 of .NET since it just calls into the underlying Lambda Builder for dotnet in general and the AWS extensions for the .NET CLI figures out what version of .NET it's building.

Proposal

dotnet7 could be replaced with dotnet to allow future custom runtime/provided runtime builds for .NET 9 and other non-Lambda supported .NET runtimes. However, to keep backwards compatibility, we could instead just add dotnet as a build method in addition to dotnet7

Things to consider:

  1. Will this require any updates to the SAM Spec - No it should not
  2. Will this require updates to the docs? - I'm not sure, but I can't seem to find dotnet7 mentioned in the docs

Additional Details

Here is the CR for when dotnet7 was added: https://github.com/aws/aws-sam-cli/pull/4410/files

@Beau-Gosse-dev Beau-Gosse-dev added stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. type/feature Feature request labels Sep 10, 2024
@Beau-Gosse-dev
Copy link
Contributor Author

I can try to find time to implement this if you think it makes sense and don't see any potential problems with it.

@hnnasit
Copy link
Contributor

hnnasit commented Sep 11, 2024

Thanks @Beau-Gosse-dev for the feature request. Let me check with the team and get back to you.

@hnnasit hnnasit added area/build sam build command and removed stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Sep 11, 2024
@hnnasit
Copy link
Contributor

hnnasit commented Sep 19, 2024

Hello @Beau-Gosse-dev, I checked with the team and they seem fine with the idea. Feel free to work on the feature request.

@hnnasit
Copy link
Contributor

hnnasit commented Oct 30, 2024

Closing as the change was release as part of SAM CLI version 1.127.0. Thanks for your contributions!

@hnnasit hnnasit closed this as completed Oct 30, 2024
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build sam build command type/feature Feature request
Projects
None yet
Development

No branches or pull requests

2 participants