Merge to master #1714
Merged
Merge to master #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: `sam deploy` - Move guided deploy prompts to its own file - New class for dealing with configuration during deploy - Utilities for printing deploy arguments and sanitizing parameter overrides * fix: save parameter values with spaces into config during guided deploy * fix: add user agent during package and deploy * fix: separate method for adding botoconfig with user-agent
Why is this change necessary? * Need to decide if this the best way to do this in the future. How does it address the issue? * Removes extra user agent information from boto calls. What side effects does this change have? * None
Why is this change necessary? * The previous pull request template just had a section to describe * changes which was not prescriptive enough to fully understand the * context How does it address the issue? * A series of questions, that need to be answered instead is proposed * which will help to set context in a more formal manner. What side effects does this change have? * None Co-authored-by: Jacob Fuss <32497805+jfuss@users.noreply.github.com>
* fix: change permissions and remove files on rmtree * fix: add `onerror` rmtreecallback docstring
Why is this change necessary? * Implementation based on the samconfig design changed course based on well reasoned discussions, but was not reflected back onto the design doc. How does it address the issue? * Design reflects more of present day implementation of `samconfig.toml` What side effects does this change have? * None TODO * Add more detail on multiple configuration files and its future.
|
Dependent on #1709 |
Why is this change necessary? * To release a new version of sam cli. How does it address the issue? * increases the version of sam cli. What side effects does this change have? * None
|
Unable to re-produce the regression test failures locally for deploy. Investigating. |
|
Looks like the publish tests are failing on ubuntu for some reason. They are all passing on Windows. Publish tests failed on some S3 permissions. Deploy test failed on CFN API throttling. Linux Windows |
sanathkr
approved these changes
Jan 8, 2020
|
Merging ignoring the failed test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change necessary?
Necessary to make a release.
How does it address the issue?
Move changes from develop to master.
None
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.