fix: Support attaching to host network #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address aws#669 Docker only supports attaching containers to the host network through the network_mode in the create. Previously, we tried to attach the container to the host network after creating. This caused the command to fail. Docker does not support attaching a container to host and bridge. Therefore, we need to handle host as a special case.
jfuss
force-pushed
the
support-host-network
branch
from
80f4318
to
a3eb631
Compare
sriram-mv
approved these changes
Oct 24, 2018
sanathkr
approved these changes
Nov 6, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #669
Docker only supports attaching containers to the host network through
the network_mode in the create. Previously, we tried to attach the
container to the host network after creating. This caused the command
to fail. Docker does not support attaching a container to host and bridge.
Therefore, we need to handle host as a special case.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.