Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Support attaching to host network #715

Merged
merged 2 commits into from
Nov 6, 2018
Merged

fix: Support attaching to host network #715

merged 2 commits into from
Nov 6, 2018

Commits on Oct 18, 2018

  1. fix: Support attaching to host network 

    Address aws#669

Docker only supports attaching containers to the host network through
the network_mode in the create. Previously, we tried to attach the
container to the host network after creating. This caused the command
to fail. Docker does not support attaching a container to host and bridge.
Therefore, we need to handle host as a special case.
    @jfuss
    jfuss committed Oct 18, 2018
    Configuration menu
    Copy the full SHA
    a3eb631 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2018

  1. Merge branch 'develop' into support-host-network

    @sriram-mv
    sriram-mv authored Nov 6, 2018
    Configuration menu
    Copy the full SHA
    f7ef963 View commit details
    Browse the repository at this point in the history