Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure endpoint resolution falls back to C2J modeled SigningName #153

Closed
jasdel opened this issue Mar 21, 2018 · 0 comments
Closed

Ensure endpoint resolution falls back to C2J modeled SigningName #153

jasdel opened this issue Mar 21, 2018 · 0 comments
Labels
v1-sync

Comments

@jasdel
Copy link
Contributor

jasdel commented Mar 21, 2018

The SDK needs to ensure that the C2J modeled SigningName is used if the modeled endpoint does not contain the SigningName field.

Related to aws/aws-sdk-go#1854
@jasdel jasdel added the v1-sync label Mar 21, 2018
@jasdel jasdel changed the title Ensure endpoint resolution includes C2J modeled SigningName Ensure endpoint resolution falls back to C2J modeled SigningName Mar 21, 2018
@jasdel jasdel mentioned this issue May 25, 2018
Closed
jasdel added a commit to jasdel/aws-sdk-go-v2 that referenced this issue May 25, 2018
@jasdel
aws/endpoints: Fix SDK endpoint signing name resolution
91e037c 
Fixes how the SDK derives service signing names. If the signing name is
not modeled in the endpoints package the service will fallback to the
signing name modeled in the service model.

Fix aws#163
Fix aws#153
V2 Port of aws/aws-sdk-go#1854
@jasdel jasdel mentioned this issue May 25, 2018
Merged
jasdel added a commit that referenced this issue May 25, 2018
@jasdel
aws/endpoints: Fix SDK endpoint signing name resolution (#181)
5f71696 
Fixes how the SDK derives service signing names. If the signing name is
not modeled in the endpoints package the service will fallback to the
signing name modeled in the service model.

Fix #163
Fix #153
V2 Port of aws/aws-sdk-go#1854
jasdel added a commit to jasdel/aws-sdk-go-v2 that referenced this issue May 25, 2018
@jasdel
Release v2.0.0-preview.4 (2018-05-25)
9918897 
Services
---
* Synced the V2 SDK with latests AWS service API definitions.

SDK Bugs
---
* `private/protocol/xml/xmlutil`: Fix XML unmarshaler not correctly unmarshaling list of timestamp values ([aws#166](aws#166))
	* Fixes a bug in the XML unmarshaler that would incorrectly try to unmarshal "time.Time" parameters that did not have the struct tag type on them.
	* Related to [aws/aws-sdk-go#1894](aws/aws-sdk-go#1894)
* `service/s3`: Fix typos for migrated S3 specific config options ([aws#173](aws#173))
	* Updates the S3 specific config error messages to the correct fields.
* `aws/endpoints`: Fix SDK endpoint signing name resolution ([aws#181](aws#181))
	* Fixes how the SDK derives service signing names. If the signing name is not modeled in the endpoints package the service will fallback to the signing name modeled in the service model.
	* Fix [aws#163](aws#163)
	* Fix [aws#153](aws#153)
	* Related to [aws/aws-sdk-go#1854](aws/aws-sdk-go#1854)
* `service/s3`: remove SelectContent until EventStream supported ([aws#175](aws#175])
	* S3's SelectContent API is not functional in the SDK yet, and was not supposed to be generated until EventStream support is available.
	* Related to [aws/aws-sdk-go#1941](aws/aws-sdk-go#1941)

SDK Enhancements
---
* `service/s3/s3manager/s3manageriface`: Add WithIterator to mock interface ([aws#156](aws#156))
	* Updates the `DownloaderAPI` and `UploaderAPI` mocking interfaces to have parity with the concrete types.
	* Fixes [aws#155](aws#155)
jasdel added a commit that referenced this issue May 26, 2018
@jasdel
Release v2.0.0-preview.4 (2018-05-25) (#182)
ff1a530 
Services
---
* Synced the V2 SDK with latests AWS service API definitions.

SDK Bugs
---
* `private/protocol/xml/xmlutil`: Fix XML unmarshaler not correctly unmarshaling list of timestamp values ([#166](#166))
	* Fixes a bug in the XML unmarshaler that would incorrectly try to unmarshal "time.Time" parameters that did not have the struct tag type on them.
	* Related to [aws/aws-sdk-go#1894](aws/aws-sdk-go#1894)
* `service/s3`: Fix typos for migrated S3 specific config options ([#173](#173))
	* Updates the S3 specific config error messages to the correct fields.
* `aws/endpoints`: Fix SDK endpoint signing name resolution ([#181](#181))
	* Fixes how the SDK derives service signing names. If the signing name is not modeled in the endpoints package the service will fallback to the signing name modeled in the service model.
	* Fix [#163](#163)
	* Fix [#153](#153)
	* Related to [aws/aws-sdk-go#1854](aws/aws-sdk-go#1854)
* `service/s3`: remove SelectContent until EventStream supported ([#175](#175])
	* S3's SelectContent API is not functional in the SDK yet, and was not supposed to be generated until EventStream support is available.
	* Related to [aws/aws-sdk-go#1941](aws/aws-sdk-go#1941)

SDK Enhancements
---
* `service/s3/s3manager/s3manageriface`: Add WithIterator to mock interface ([#156](#156))
	* Updates the `DownloaderAPI` and `UploaderAPI` mocking interfaces to have parity with the concrete types.
	* Fixes [#155](#155)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v1-sync
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jasdel