Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AWS_METADATA_SERVICE_TIMEOUT + AWS_METADATA_SERVICE_NUM_ATTEMPTS #3495

Closed
lifeofguenter opened this issue Aug 20, 2020 · 8 comments
Labels
feature-request A feature should be added or improved.

Comments

@lifeofguenter
Copy link

Would be great if AWS_METADATA_SERVICE_TIMEOUT and AWS_METADATA_SERVICE_NUM_ATTEMPTS could be implemented analogue to boto/python-sdk.

@lifeofguenter lifeofguenter added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 20, 2020
@diehlaws diehlaws removed the needs-triage This issue or PR still needs to be triaged. label Aug 20, 2020
@diehlaws
Copy link
Contributor

Thanks for reaching out to us about this @lifeofguenter. Can you provide some details regarding your use case that necessitates these environment variables? Are you currently unable to set these values in your config without them? Describing any other issues you're running into related to this would help us implement support for these in a useful manner.

@diehlaws diehlaws added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Aug 20, 2020
@lifeofguenter
Copy link
Author

This was recommended by aws-support for boto3/aws-cli due to IMDS being a service with rate limits.

However, in our case, we heavily use terraform which uses the aws-sdk-go library, so it would be great if one could set these settings here as well.

Context: hashicorp/terraform#25835 (comment)

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Aug 22, 2020
@mdgreenfield
Copy link

We have also started running into this issue. It would be great if we could get these env vars supported for parity with boto3.

@github-actions
Copy link

We have noticed this issue has not received attention in 1 year. We will close this issue for now. If you think this is in error, please feel free to comment and reopen the issue.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label May 15, 2022
@lifeofguenter
Copy link
Author

still relevant?

@github-actions github-actions bot removed the closing-soon This issue will automatically close in 4 days unless further comments are made. label May 16, 2022
@abvm659
Copy link

abvm659 commented Jun 9, 2022

Please do not close this - e.g. terraform stopped supporting its custom metadata timeout solution and relies only on AWS_METADATA_SERVICE_TIMEOUT - which is not supported in go aws sdk yet - which is very strange. For large scale usage of terraform and in our go applications, unability to set timeout is causing huge issue. There is no good workaround for that (one can only retrigger the calls if they fail after some random wait time).

@jonathan-russo
Copy link

I would like to see this implemented as well. We are getting intermittent IMDS errors on our Jenkins server when attempting to apply Terraform:

failed to refresh cached credentials, no EC2 IMDS role found, operation error ec2imds: GetMetadata, canceled, context deadline exceeded

It would be nice to set AWS_METADATA_SERVICE_NUM_ATTEMPTS and/or AWS_METADATA_SERVICE_TIMEOUT to have the SDK re-attempt the request after the credential rollover.

Copy link

github-actions bot commented Apr 1, 2024

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

6 participants