-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Execution and Request timeouts #29
Comments
Is there any update on this? While doing fault tolerance testing I noticed that the timeouts work correctly on the sync clients but not on the async clients. This will be a blocker for going to production. |
@tddmonkey Would being able to configure the socket connect and read timeouts be sufficient to unblock you? |
@millems I'm using Reactor around all my code so pushing a a) I have to remember to do this! |
Step Functions' client is unusable without being able to set the request timeout. All requests for @millems How do you configure read timeouts? |
The read timeout can be configured in the HTTP client. For sync clients, that would be the ApacheSdkHttpClientFactory apacheConfig = ApacheSdkHttpClientFactory.builder()
.connectionTimeout(Duration.ofSeconds(65))
.maxConnections(1_000)
.build();
SWFClient client = SWFClient.builder()
.httpConfiguration(c -> c.httpClientFactory(apacheConfig))
.build(); |
Execution and request timeouts are currently exposed on the client configuration override object, but don't actually work. This functionality should be fixed.
The text was updated successfully, but these errors were encountered: