Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution and Request timeouts #29

Closed
millems opened this issue Jul 3, 2017 · 6 comments
Closed

Execution and Request timeouts #29

millems opened this issue Jul 3, 2017 · 6 comments
Labels
1.x Parity feature-request A feature should be added or improved.

Comments

@millems
Copy link
Contributor

millems commented Jul 3, 2017

Execution and request timeouts are currently exposed on the client configuration override object, but don't actually work. This functionality should be fixed.

@tddmonkey
Copy link

Is there any update on this? While doing fault tolerance testing I noticed that the timeouts work correctly on the sync clients but not on the async clients. This will be a blocker for going to production.

@millems
Copy link
Contributor Author

millems commented Nov 17, 2017

@tddmonkey Would being able to configure the socket connect and read timeouts be sufficient to unblock you?

@tddmonkey
Copy link

@millems I'm using Reactor around all my code so pushing a .timeout() on to there was sufficient for now. It will be a pain moving forward as:

a) I have to remember to do this!
b) Timeouts will be configured in 2 places (on the actual call and also on the non-functioning config).

@alvaroc1
Copy link

Step Functions' client is unusable without being able to set the request timeout. All requests for GetActivityTask timeout before the server can close the connection (long-polling).

@millems How do you configure read timeouts?

@millems
Copy link
Contributor Author

millems commented Jan 15, 2018

The read timeout can be configured in the HTTP client. For sync clients, that would be the ApacheHttpConfigurationFactory:

ApacheSdkHttpClientFactory apacheConfig = ApacheSdkHttpClientFactory.builder()
                                                                    .connectionTimeout(Duration.ofSeconds(65))
                                                                    .maxConnections(1_000)
                                                                    .build();
SWFClient client = SWFClient.builder()
                            .httpConfiguration(c -> c.httpClientFactory(apacheConfig))
                            .build();

@zoewangg
Copy link
Contributor

Implemented in #724 and #657

@justnance justnance added feature-request A feature should be added or improved. and removed Feature Request labels Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x Parity feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

7 participants