Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override SCHEDULED_EXECUTOR_SERVICE for S3Crt client #4884

Closed
1 of 2 tasks
scrocquesel opened this issue Feb 2, 2024 · 2 comments
Closed
1 of 2 tasks

Allow to override SCHEDULED_EXECUTOR_SERVICE for S3Crt client #4884

scrocquesel opened this issue Feb 2, 2024 · 2 comments
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@scrocquesel
Copy link
Contributor

Describe the feature

Follow up of #4841 but for scheduled executor service

Use Case

In quarkus, there is already a global elastic pool that should be used for this purpose

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS Java SDK version used

2.23.6

JDK version used

17

Operating System and version

linux

@scrocquesel scrocquesel added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 2, 2024
@scrocquesel
Copy link
Contributor Author

As mentionned, the scheduled executor is not used by the s3 crt client. Closing as not necessary.

          @scrocquesel ah, sorry, I missed that. `SCHEDULED_EXECUTOR_SERVICE` is not directly used in S3 CRT client though. It's used in retry layer and waiters, and retry in S3 CRT client is handled in the native CRT library.

Originally posted by @zoewangg in #4841 (comment)

Copy link

github-actions bot commented Feb 2, 2024

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

1 participant