Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cucumber): use waiters in integration tests #1792

Merged
merged 5 commits into from
Dec 18, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Dec 15, 2020

Issue #, if available:
N/A

Description of changes:
use waiters in integration tests

DynamoDB
> yarn test:integration-legacy features/dynamodb
yarn run v1.22.5
$ cucumber-js --fail-fast features/dynamodb
...............................

6 scenarios (6 passed)
19 steps (19 passed)
1m00.205s
Done in 62.98s.
EC2
> yarn test:integration-legacy features/ec2     
yarn run v1.22.5
$ cucumber-js --fail-fast features/ec2
...............

3 scenarios (3 passed)
9 steps (9 passed)
0m21.490s
Done in 24.31s.
S3
> yarn test:integration-legacy features/s3
yarn run v1.22.5
$ cucumber-js --fail-fast features/s3
..................................................................................................................................................................................................................

24 scenarios (24 passed)
138 steps (138 passed)
1m14.160s
Done in 82.34s.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-io
Copy link

codecov-io commented Dec 15, 2020

Codecov Report

Merging #1792 (254ff02) into master (de75f7e) will decrease coverage by 0.54%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1792      +/-   ##
==========================================
- Coverage   79.77%   79.23%   -0.55%     
==========================================
  Files         325      364      +39     
  Lines       12087    15056    +2969     
  Branches     2553     3205     +652     
==========================================
+ Hits         9643    11929    +2286     
- Misses       2444     3127     +683     
Impacted Files Coverage Δ
protocol_tests/aws-json/models/models_0.ts 79.36% <0.00%> (-20.64%) ⬇️
protocol_tests/aws-restjson/models/models_0.ts 89.43% <0.00%> (-10.57%) ⬇️
...rotocol_tests/aws-restxml/protocols/Aws_restXml.ts 64.10% <0.00%> (-2.15%) ⬇️
...ackages/node-http-handler/src/node-http-handler.ts 98.00% <0.00%> (-2.00%) ⬇️
packages/middleware-sdk-sqs/src/send-message.ts 86.66% <0.00%> (-0.84%) ⬇️
protocol_tests/aws-query/protocols/Aws_query.ts 66.34% <0.00%> (-0.38%) ⬇️
...kages/middleware-sdk-sqs/src/send-message-batch.ts 92.30% <0.00%> (-0.29%) ⬇️
...kages/fetch-http-handler/src/fetch-http-handler.ts 9.30% <0.00%> (-0.23%) ⬇️
protocol_tests/aws-ec2/protocols/Aws_ec2.ts 66.93% <0.00%> (-0.01%) ⬇️
packages/url-parser-node/src/index.ts 100.00% <0.00%> (ø)
... and 180 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f9e56f...254ff02. Read the comment docs.

@trivikr
Copy link
Member Author

trivikr commented Dec 17, 2020

This PR is blocked on #1799

@trivikr trivikr marked this pull request as ready for review December 17, 2020 21:26
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: again. Thank you for taking care of this!

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants