-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cucumber): use waiters in integration tests #1792
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov Report
@@ Coverage Diff @@
## master #1792 +/- ##
==========================================
- Coverage 79.77% 79.23% -0.55%
==========================================
Files 325 364 +39
Lines 12087 15056 +2969
Branches 2553 3205 +652
==========================================
+ Hits 9643 11929 +2286
- Misses 2444 3127 +683
Continue to review full report at Codecov.
|
47337f6
to
c86d1d3
Compare
This PR is blocked on #1799 |
87338f2
to
254ff02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again. Thank you for taking care of this!
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue #, if available:
N/A
Description of changes:
use waiters in integration tests
DynamoDB
EC2
S3
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.