Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(util-dynamodb): unmarshall small numbers or those in scientific notation #2017

Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Feb 10, 2021

Issue

Fixes: #1983

Description

supports unmarshalling small numbers or those using scientific notation

Testing

Unit tests


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr changed the title fix: unmarshall small numbers or those in scientific notation fix(util-dyynamodb): unmarshall small numbers or those in scientific notation Feb 10, 2021
@trivikr trivikr changed the title fix(util-dyynamodb): unmarshall small numbers or those in scientific notation fix(util-dynamodb): unmarshall small numbers or those in scientific notation Feb 10, 2021
@codecov-io
Copy link

Codecov Report

Merging #2017 (099ba98) into master (f2a47e8) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2017      +/-   ##
==========================================
+ Coverage   79.30%   79.35%   +0.04%     
==========================================
  Files         368      368              
  Lines       15132    15193      +61     
  Branches     3222     3253      +31     
==========================================
+ Hits        12001    12056      +55     
- Misses       3131     3137       +6     
Impacted Files Coverage Δ
packages/util-waiter/src/utils/validate.ts 81.81% <0.00%> (-18.19%) ⬇️
...process-arnables-plugin/update-arnables-request.ts 91.30% <0.00%> (-8.70%) ⬇️
lib/storage/src/data-chunk/readable-helper.ts 86.84% <0.00%> (-5.47%) ⬇️
packages/s3-request-presigner/src/presigner.ts 94.73% <0.00%> (-5.27%) ⬇️
...s/middleware-bucket-endpoint/src/bucketHostname.ts 98.27% <0.00%> (-1.73%) ⬇️
packages/util-dynamodb/src/convertToAttr.ts 98.82% <0.00%> (-1.18%) ⬇️
packages/util-waiter/src/poller.ts 100.00% <0.00%> (ø)
packages/util-waiter/src/waiter.ts 100.00% <0.00%> (ø)
protocol_tests/aws-ec2/endpoints.ts 81.48% <0.00%> (ø)
protocol_tests/aws-json/endpoints.ts 81.48% <0.00%> (ø)
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d9a469...099ba98. Read the comment docs.

@trivikr trivikr force-pushed the remove-IEEE-754-floating-point-arithmetic-check branch from 099ba98 to b88f4b6 Compare February 10, 2021 19:23
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: b88f4b6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@trivikr trivikr merged commit 80a8094 into aws:master Feb 11, 2021
@trivikr trivikr deleted the remove-IEEE-754-floating-point-arithmetic-check branch February 11, 2021 17:12
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unmarshalling small numbers gives unexpected errors
4 participants