Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codegen): pin smithy dependencies to minor version 1.6.x #2153

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Mar 18, 2021

Issue

Fixes: #2151
Fixes: #2152

Description

Pin smithy dependencies to minor version 1.6.x as both our Java CI as well as generate-clients scripts are failing.

Testing

Verified that Java CI and generate-clients script was successful.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 52d1642
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@trivikr trivikr merged commit 906e4b0 into aws:main Mar 18, 2021
@trivikr trivikr deleted the pin-smithy-1.6.x branch March 18, 2021 15:37
@mtdowling
Copy link
Member

TODO: fix this repo to work with 1.7

@trivikr
Copy link
Member Author

trivikr commented Mar 18, 2021

TODO:

  • Publish smithy-typescript to maven.
  • Add Gradle lockfiles in aws-sdk-js-v3 and smithy-typescript so that dependency version numbers are locked.

@github-actions
Copy link

github-actions bot commented Apr 2, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants