Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codegen): pass settings to createSymbolProvider #2196

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Mar 30, 2021

Issue

Fixes: #2195

Description

pass settings to createSymbolProvider

Testing

codegen-ci


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: e28058b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@62ea787). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2196   +/-   ##
=======================================
  Coverage        ?   61.83%           
=======================================
  Files           ?      453           
  Lines           ?    23287           
  Branches        ?     5516           
=======================================
  Hits            ?    14399           
  Misses          ?     8888           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62ea787...e28058b. Read the comment docs.

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@trivikr trivikr merged commit 94aefce into aws:main Mar 30, 2021
@trivikr trivikr deleted the pass-settings-createSymbolProvider branch March 30, 2021 15:23
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The java codegen-ci is failing on main branch with error in method createSymbolProvider
4 participants