fix(xml-builder): xml entity encoding for more characters #2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XML entity encoding for carriage return, line feed, next line, line separator characters, quote and single quote
Codecov Report
@@ Coverage Diff @@
## main #2309 +/- ##
=======================================
Coverage ? 59.99%
=======================================
Files ? 470
Lines ? 24749
Branches ? 5862
=======================================
Hits ? 14847
Misses ? 9902
Partials ? 0 Continue to review full report at Codecov.
|
trivikr
approved these changes
Apr 28, 2021
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XML entity encoding for carriage return, line feed, next line, line separator characters,
quote and single quote
JS-2318
Open question
This can bring potential, but unlikely, breaking change because the
"and'which previously unencoded, is now encoded to"'to match the behavior of other SDKs, like Java v2. But I've confirmed that the same content after deserialized is not changed.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.