fix(middleware-retry): defaultStrategy handles any error #2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2349 +/- ##
=======================================
Coverage ? 60.06%
=======================================
Files ? 472
Lines ? 24838
Branches ? 5883
=======================================
Hits ? 14918
Misses ? 9920
Partials ? 0 Continue to review full report at Codecov.
|
The lower level stacks than throw anything to retry strategy in practice, so casting them to SdkError type is unsafe. With this change the retryStrategy will do best effort to convert the thrown any object to SdkError and then supply to retryDecider and so on. Another change is making SdkError type more general. It previously requires $fault, $metadata, which is obviously incorrect. Error thrown by SDK itself never contains these keys. So I mark them optional. Granted this is a breaking change to function interface like RetryDecider, but anyone depending it being required should already fail anyway.
AllanZhengYP
force-pushed
the
fix-retry-catch
branch
from
89f0057
to
a1650a7
Compare
trivikr
approved these changes
May 4, 2021
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2292
The lower level stacks than throw anything to retry strategy in
practice, so casting them to SdkError type is unsafe. With this
change the retryStrategy will do best effort to convert the
thrown any object to SdkError and then supply to retryDecider
and so on.
Another change is making SdkError type more general. It previously
requires $fault, $metadata, which is obviously incorrect. Error
thrown by SDK itself never contains these keys. So I mark them
optional. Granted this is a breaking change to function interface
like RetryDecider, but anyone depending it being required should
already fail anyway.
/cc @just-boris
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.