feat(middleware-bucket-endpoint): arn supports fips & handles global regions #2392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All ARN-format bucket disallows global client region like s3-external-1 or s3 global endpoint(aws-global). Westeros and Output ARN allows FIPS region as long as the pseudo region compliant with the arn region
… regions
3 formats of ARN s3 accepts is touched in this change: Outposts ARN, AccessPoint ARN,
and ObjectLambda ARN. Here are the changes:
* All of the 3 ARN formats no longer accept s3 global region: s3-global("s3.amazonaws.com"),
s3-external-1("s3-external-1.amazonaws.com").
* Outposts ARN no longer support FIPS region, e.g. fips-us-gov-east-1
* AccessPoint ARN accepts FIPS regions with a special endpoint format.
* ObjectLambda ARN accepts FIPS regions with a special endpoint format.
Codecov Report
@@ Coverage Diff @@
## main #2392 +/- ##
=======================================
Coverage ? 59.00%
=======================================
Files ? 484
Lines ? 26077
Branches ? 6193
=======================================
Hits ? 15386
Misses ? 10691
Partials ? 0 Continue to review full report at Codecov.
|
trivikr
approved these changes
May 14, 2021
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 formats of ARN s3 accepts is touched in this change: Outposts ARN, AccessPoint ARN,
and ObjectLambda ARN. Here are the changes:
s3-external-1("s3-external-1.amazonaws.com").
{accesspoint-name}-{account-id}.s3-accesspoint[-fips][.dualstack].{region}.{partition}{accesspointName}-{accountId}.s3-object-lambda[-fips].{region}.{dnsSuffix}#JS-2608
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.