fix(credential-provider-imds): destroy request handle on promise resolve/reject #2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2452 +/- ##
=======================================
Coverage ? 59.55%
=======================================
Files ? 493
Lines ? 26374
Branches ? 6265
=======================================
Hits ? 15708
Misses ? 10666
Partials ? 0 Continue to review full report at Codecov.
|
samchungy
changed the title
samchungy
changed the title
samchungy
changed the title
samchungy
changed the title
AllanZhengYP
approved these changes
Jun 17, 2021
|
/cc @trivikr |
trivikr
approved these changes
Jun 17, 2021
trivikr
changed the title
This was referenced Jun 22, 2021
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#2451
Description
Issue in the
credential-provider-imdspackage.Kills the dangling open request handle in
credential-provider-imdsafter the promise resolves or rejects. If it is not killed manually we are relying on Node.js to clean it up which can take a long time or just simply never done. In my tests, a successful request remained open for 16 hours on a buildkite build. This causes issues especially with testing libraries like Jest which wait for all handles to be closed.Testing
How was this change tested?
Example Repo:
https://github.com/samchungy/jest-aws-sdk-v3-open-handle
Additional context
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.