Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clients): documentation for config.region for new clients #2468

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jun 6, 2021

Issue

Refs: #2464

Description

The documentation for config.region for new clients is different.
For example, for new client client-applicationcostprofiler it has suffix or use as signingRegion

/**
* The AWS region to which this client will send requests or use as signingRegion
*/
region?: string | __Provider<string>;

The suffix is missing in old clients:

/**
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

It's likely that this suffix was mistakenly added when clients were updated in #2464

Testing

Verified that the documentation for region is for new clients is same as that in previous clients.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@72cc2dc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2468   +/-   ##
=======================================
  Coverage        ?   59.54%           
=======================================
  Files           ?      493           
  Lines           ?    26357           
  Branches        ?     6261           
=======================================
  Hits            ?    15695           
  Misses          ?    10662           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72cc2dc...b21c805. Read the comment docs.

@trivikr trivikr merged commit 3bd30bb into aws:main Jun 7, 2021
@trivikr trivikr deleted the fix-region-docs branch June 7, 2021 14:49
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants