-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(credential-providers): collect credential providers in single package #2672
feat(credential-providers): collect credential providers in single package #2672
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2672 +/- ##
=======================================
Coverage ? 58.93%
=======================================
Files ? 528
Lines ? 28991
Branches ? 7188
=======================================
Hits ? 17085
Misses ? 11906
Partials ? 0 Continue to review full report at Codecov.
|
Equivalent to ChainableTemporaryCredentials class in v2 SDK. The provider is not re-exported from standalone package or used in the credential- provider-ini because the roleAssumers function interface in other packages does not suite the usecase of this provider. In roleAssumer interface, the master credential is required. It's not true for fromTemporaryCredentials, where master credentials can be skipped, in which case the default credential will be used.
88b8231
to
f5b33d5
Compare
f5b33d5
to
aacac32
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
8462240
to
9d0a833
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Resolves #2393
Resolves #1796
Description
This package also provides
fromTemporaryCredentials
, which equivalent toChainableTemporaryCredentials
class in v2Added an all-in-one doc for all the providers: https://github.com/aws/aws-sdk-js-v3/blob/719a49b36eb4bf2837c54cf35edb30292ad032b7/packages/credential-providers/README.md
Testing
Unit test
Additional context
Add any other context about the PR here.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.