feat(xhr-http-handler): add XMLHttpRequest http handler to use with lib-storage Upload #3798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
commented
Jul 13, 2022
Co-authored-by: AllanZhengYP <zheallan@amazon.com>
AllanZhengYP
approved these changes
Jul 15, 2022
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Finer upload progress grain (#3101)
Description
Adds an XMLHttpRequest http handler. This can be used instead of the fetch handler in certain cases.
Specifically, it gives fine-grained progress updates for single part and multi-part uploads via
lib-storage'sUpload.Testing
Unit tests and manual browser testing with
Uploadfromlib-storage.Additional context
This has only been tested against S3 in browsers.