Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clients): use migrated @smithy packages #4873

Merged
merged 5 commits into from Jun 28, 2023

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Jun 22, 2023

Issue

Issue number, if available, prefixed with "#"

Description

This PR updates packages, codegen and applies codegen to clients to use @smithy packages.

Relies on codegen changes in smithy-lang/smithy-typescript#791

Testing

How was this change tested?

Additional context

Add any other context about the PR here.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@srchase srchase requested a review from a team as a code owner June 22, 2023 18:20
@srchase srchase force-pushed the migrate-packages branch 7 times, most recently from c87b653 to 54549b5 Compare June 26, 2023 22:33
@trivikr trivikr changed the title Update codegen to use migrated @smithy packages feat(clients): use migrated @smithy packages Jun 28, 2023
@srchase srchase force-pushed the migrate-packages branch 4 times, most recently from 36cf994 to d246243 Compare June 28, 2023 18:30
@trivikr trivikr merged commit d036e2e into aws:main Jun 28, 2023
3 checks passed
@srchase srchase deleted the migrate-packages branch June 28, 2023 20:42
trentm added a commit to elastic/apm-agent-nodejs that referenced this pull request Jun 29, 2023
In aws/aws-sdk-js-v3#4873 aws-sdk v3 moved
@aws-sdk/smithy-client to @smithy/smithy-client. This will now
instrument either package name.

Fixes: #3454
m-radzikowski added a commit to m-radzikowski/aws-sdk-client-mock that referenced this pull request Jul 1, 2023
AWS SDK v3.363.0 migrated from @aws-sdk/types to @smithy/types. See:
- https://github.com/aws/aws-sdk-js-v3/releases/tag/v3.363.0
- aws/aws-sdk-js-v3#4873
- #168
trentm added a commit to elastic/apm-agent-nodejs that referenced this pull request Jul 4, 2023
…se (#3455)

In aws/aws-sdk-js-v3#4873 aws-sdk v3 moved
@aws-sdk/smithy-client to @smithy/smithy-client. This will now
instrument either package name.

Fixes: #3454
@xconverge xconverge mentioned this pull request Jul 5, 2023
3 tasks
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants