feat: requestHandler ctor param pass-through #5820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 21, 2024
kuhe
force-pushed
the
feat/requestHandler
branch
from
f17c7a1
to
6ac2a9a
Compare
kuhe
force-pushed
the
feat/requestHandler
branch
from
3c92c8e
to
490511f
Compare
siddsriv
approved these changes
Feb 23, 2024
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
See smithy-lang/smithy-typescript#1167 for clarifying example.
Description
Simplify how to modify the underlying requestHandler or its
http(s).Agents.Checklist
write new integ test to ensure all requestHandler config styles work
new Smithy hash
update Smithy pkg versions
e2e
e2e:legacy