Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds changelog to JS SDK. Adds script for automating update of change… #1045

Merged
merged 5 commits into from Jul 19, 2016
Merged

Adds changelog to JS SDK. Adds script for automating update of change… #1045

merged 5 commits into from Jul 19, 2016

Conversation

LiuJoyceC
Copy link
Contributor

…log based on json files in .changes directory.

/cc @chrisradek

@coveralls
Copy link

coveralls commented Jul 6, 2016 •
edited

Coverage Status

Coverage remained the same at 89.017% when pulling dcabbf5 on LiuJoyceC:changelog into 0f20de2 on aws:master.

@LiuJoyceC
Copy link
Contributor Author

I couldn't add the .changes directory yet because I can't commit an empty directory, but we can add it when the first changelog json is added.

chrisradek
chrisradek reviewed Jul 6, 2016
View reviewed changes
scripts/update-changelog
if (!change.type || !change.category || !change.description) {
throw new Error('json not in correct format');
}
entry += '\n\t<li>' + change.type + ': ' + change.category + ': ' +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to use standard markdown instead of html:
https://guides.github.com/features/mastering-markdown/

@coveralls
Copy link

coveralls commented Jul 7, 2016 •
edited

Coverage Status

Coverage remained the same at 89.017% when pulling 57eaf84 on LiuJoyceC:changelog into 0f20de2 on aws:master.

@LiuJoyceC
Copy link
Contributor Author

For now, service updates for releases will need to have JSON files manually created in the next-release directory along with the JSON files for PRs.

@coveralls
Copy link

coveralls commented Jul 8, 2016 •
edited

Coverage Status

Coverage remained the same at 89.017% when pulling 38bc99a on LiuJoyceC:changelog into 9787eaa on aws:master.

@chrisradek
Copy link
Contributor

Do you mind adding a README for these new scripts that explains what they do, or how they should be run? I know we don't expect these particular scripts to be run by users but it would still be helpful for future contributors.

@coveralls
Copy link

coveralls commented Jul 8, 2016 •
edited

Coverage Status

Coverage remained the same at 89.017% when pulling d14d290 on LiuJoyceC:changelog into 9787eaa on aws:master.

@LiuJoyceC
Copy link
Contributor Author

New changes have been pushed. The README contains a fictional example of an entry in the changelog that we should swap out for a real example when we create our first real entry.

@coveralls
Copy link

coveralls commented Jul 8, 2016 •
edited

Coverage Status

Coverage remained the same at 89.017% when pulling 2a74fe7 on LiuJoyceC:changelog into 9787eaa on aws:master.

@chrisradek
Copy link
Contributor

:shipit:

@LiuJoyceC
Adds changelog to JS SDK. Adds script for automating update of change…
5b93a50 
…log based on json files in .changes directory.
@LiuJoyceC
Adds create-changelog script to recreate entire changelog based on js…
0a9b21d 
…on files in .changes/ directory. Modified update-changelog script to use markdown syntax rather than HTMl, and changed to use parseInt to convert numeric strings to numbers.
@LiuJoyceC
Adds release script and replaces update-changelog with util.js. In ut…
9a19bba 
…il.js, modularized functionality of update-changelog to prevent duplicate logic and unnecessary reads and writes, which did not occur when update-changelog was first written as a standalone script but became a problem when the create-changelog and release scripts depended on it. All scripts relating to the changelog have been moved into its own subdirectory.
@LiuJoyceC
Modified startContent (used for create-changelog) to use predefined i…
28f0b7c 
…nsertMarker and versionMarker rather than hard-coded
@LiuJoyceC
Adds README. Fixes bug in util.checkAndNormalizeVersion. Adds more ch…
a9c8432 
…ecks for errors. Logs message for each fs operation that modifies the filesystem.
@coveralls
Copy link

coveralls commented Jul 18, 2016 •
edited

Coverage Status

Coverage remained the same at 88.749% when pulling a9c8432 on LiuJoyceC:changelog into 8ba7874 on aws:master.

@LiuJoyceC LiuJoyceC merged commit 2e54f33 into aws:master Jul 19, 2016
chrisradek added a commit that referenced this pull request Jul 19, 2016
@chrisradek
Tag release v2.4.8
466490f 
References:
  #1020, #1045, #1048, #1052, #1054, #1059
LiuJoyceC added a commit that referenced this pull request Jul 26, 2016
@LiuJoyceC
Tag release v2.4.10
155bf58 
References:
  #1020, #1045, #1048, #1052, #1054, #1057, #1058, #1059,
  #1067
LiuJoyceC added a commit that referenced this pull request Jul 29, 2016
@LiuJoyceC
Tag release v2.4.11
11c8d80 
References:
  #1020, #1045, #1048, #1052, #1054, #1057, #1058, #1059,
  #1067, #1074, #1077
@lock
Copy link

lock bot commented Sep 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@chrisradek chrisradek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LiuJoyceC @coveralls @chrisradek