docs/fix: Explicit about bucket name uniqueness #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's easy to miss that line that myBucket needs to be unique-- provide whitespace & IMPORTANT to call it out These docs need a unique S3 bucket name comment: https://aws.amazon.com/sdk-for-node-js/
|
Hi @valgaze Thanks for the PR. I will merge it in. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's easy to miss the line that s3 bucket names must be to be unique-- provided whitespace & IMPORTANT to call it out.
The error is a bit cryptic & reads like a permissions error:
These docs need a unique S3 bucket name comment: https://aws.amazon.com/sdk-for-node-js/