Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds add-change CLI to allow easy creation of changelog entry JSON files. #1059

Merged
merged 1 commit into from Jul 15, 2016
Merged

Adds add-change CLI to allow easy creation of changelog entry JSON files. #1059

merged 1 commit into from Jul 15, 2016

Conversation

chrisradek
Copy link
Contributor

We can merge our README.md entries together, I included your README entries to make it easier to see what the final README will look like.

Tested the cli on mac os x terminal and windows command prompt.

/cc @LiuJoyceC

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 88.677% when pulling b5b1bbf on chrisradek:script/add-change into d61f325 on aws:master.

@coveralls
Copy link

coveralls commented Jul 14, 2016

Coverage Status

Coverage remained the same at 88.749% when pulling b5b1bbf on chrisradek:script/add-change into d61f325 on aws:master.

@LiuJoyceC
Copy link
Contributor

Not a big deal, but for the sake of consistency (and therefore less of a need to refer back to documentation to remind oneself of which command to run for which script), it would be nice to add #!/usr/bin/env node at the beginning of of the add-change script so the user could run it with or without prepending node to their command, like the other scripts in the script folder. But otherwise, :shipit: !

@chrisradek
Copy link
Contributor Author

The reason I didn't add #!/usr/bin/env node was because that won't work in a windows environment. I could add a separate script for unix/windows, but that didn't seem easier than just calling the script with node.

@LiuJoyceC
Copy link
Contributor

🐑

@chrisradek chrisradek merged commit 8ba7874 into aws:master Jul 15, 2016
@chrisradek chrisradek deleted the script/add-change branch July 15, 2016 21:43
chrisradek added a commit that referenced this pull request Jul 19, 2016
LiuJoyceC added a commit that referenced this pull request Jul 26, 2016
LiuJoyceC added a commit that referenced this pull request Jul 29, 2016
@lock
Copy link

lock bot commented Sep 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants